-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to Kubernetes support period info #32986
Conversation
Welcome @samnoon1971! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-io-main-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
With a couple of tweaks, this will be good to merge.
/retitle Add links to Kubernetes support period info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samnoon1971 could you edit the commit messages here to not mention the issue that you're fixing? Because of issues with forks, we prefer not to do that.
https://linuxize.com/post/change-git-commit-message/ has some good tips on how to make that happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samnoon1971 could you edit the commit messages here to not mention the issue that you're fixing? Because of issues with forks, we prefer not to do that.
https://linuxize.com/post/change-git-commit-message/ has some good tips on how to make that happen.
(I forgot to mark the previous review as Request changes)
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Hi @sftim, Please check the changes as per suggested. Thanks! |
Hi there! I added the necessary hyperlinks, would you please verify them?
Regards